Update WindowsPort.md as per #129 and other advisories #130

citkane · 2025-08-05T12:47:30Z

Make users aware that cloning into a parent git repository can cause failure.
Make users aware that having "C++ Clang Tools for Windows" installed may cause build failure and offer a workaround in the Webkit Command Prompt script.
As per Windows port documentation errata for choco install cmake #129, choco installs Cmake 4+ by default since ~March 2025. This causes downstream issues with vcpkg woff2. Use Cmake 3.23 instead.
Add option to set ccmake for pch in the Webkit Command Prompt

- Make users aware that shallow cloning of the WebKit repo will cause failure - Make users aware that "C++ Clang Tools for Windows" will cause build failure and offer workaround in the Webkit Command Prompt script. - Add option to set ccmake for pch in the Webkit Command Prompt

donny-dont

Overall looks good just some follow ups for you and we can squash and land

docs/Ports/WindowsPort.md

donny-dont · 2025-08-13T16:49:03Z

docs/Ports/WindowsPort.md


 Install CMake, Perl, Python, Ruby, gperf \([GnuWin32 Gperf](https://gnuwin32.sourceforge.net/packages/gperf.htm)\), LLVM, and Ninja.
-Python 3.12 has [a problem for WebKit at the moment](https://webkit.org/b/261113). Use Python 3.11.
+- Python 3.12 has [a problem for WebKit at the moment](https://webkit.org/b/261113). Use Python 3.11.


I’m not 100% sure this is still an issue and I’m not sure if Python 3.13 is good to use. Might be worth verifying this.

Python 3.13 (latest choco) compiles WebKit for me with the following caveates:

I did not flush ccache or __pycache__

I am not building or running any tests

I am only building Release

While choco install python311 works, it is no longer on the Chocolately package list. I don't really understand the underlying issue at a low level to make a call on this, but maybe the documentation should advise to do choco install python --version=3.11.x only if problems are experienced?

I’m not sure if that works because you can have multiple python versions installed

@iangrunert any thoughts on this?

I'm using Python 3.12 and haven't ran into issues as of yet.

From CMake configure: -- Found Python: C:/Python313/python.exe (found version "3.13.6") found components: Interpreter

I think this is hard-coded somewhere obfuscated to PATH. I tried setting the PYTHON env variable to something else from the WebKit shell script, and it got overwritten. Chocolately should however fix PATH to whatever version is installed last, even though multiple version remain on disk.

Let me know if we are good with 3.13.x. If so, we can just document python for choco install.

donny-dont · 2025-08-13T16:49:54Z

docs/Ports/WindowsPort.md


 Install CMake, Perl, Python, Ruby, gperf \([GnuWin32 Gperf](https://gnuwin32.sourceforge.net/packages/gperf.htm)\), LLVM, and Ninja.
-Python 3.12 has [a problem for WebKit at the moment](https://webkit.org/b/261113). Use Python 3.11.
+- Python 3.12 has [a problem for WebKit at the moment](https://webkit.org/b/261113). Use Python 3.11.
+- Cmake 4+ has [a dowstream problem for vcpkg woff2 at the moment](https://github.com/WebKit/Documentation/issues/129). Use Cmake 3.31.8.


Think we just want to say the latest CMake 3.x version to future proof this.

See revised

Just a complete nit but it’s CMake not Cmake

I share similar afflictions. Updated to CMake.

donny-dont · 2025-08-13T16:51:24Z

docs/Ports/WindowsPort.md


 You can use [Chocolatey](https://community.chocolatey.org/) to install the tools.
 [ActivePerl chocolatey package](https://community.chocolatey.org/packages/ActivePerl) has a problem and no package maintainer now.
 XAMPP includes Perl, and running layout tests needs XAMPP. Install XAMPP instead.

 ```
-choco install -y xampp-81 python311 ruby git cmake gperf llvm ninja
+choco install -y xampp-81 python311 ruby git gperf llvm ninja
+choco install -y cmake --version=3.31.8


I think we need a choco pin command with this so when someone upgrades they don’t end up with CMake 4. Ideally the version could be <4.0.0 so if there is another 3.x release it’ll upgrade.

See revised

donny-dont

@iangrunert any other suggestions for this?

donny-dont · 2025-08-13T22:25:40Z

docs/Ports/WindowsPort.md

+# Use the latest 3.x version of cmake available
+choco search -e cmake -a
+choco install -y cmake --version=3.x.x
+choco pin add -n=cmake


I’m not chocolatey expert would this work if a new 3.x.x is released and update is called?

I think that pin means pin, but we can be more helpful with the message (see update)

donny-dont · 2025-08-13T22:37:01Z

docs/Ports/WindowsPort.md


 Install CMake, Perl, Python, Ruby, gperf \([GnuWin32 Gperf](https://gnuwin32.sourceforge.net/packages/gperf.htm)\), LLVM, and Ninja.
-Python 3.12 has [a problem for WebKit at the moment](https://webkit.org/b/261113). Use Python 3.11.
+- Python 3.12+ potentially has [a problem for WebKit in some contexts](https://webkit.org/b/261113). Use Python 3.11.x if you experience issues.
+- CMake 4+ has [a dowstream problem for vcpkg woff2 at the moment](https://github.com/WebKit/Documentation/issues/129). Use CMake 3.x.


Missed the typo for downstream

citkane added 2 commits August 5, 2025 13:45

Update WindowsPort.md

dfc98a3

As per WebKit#129

citkane changed the title ~~Update WindowsPort.md as per #129~~ Update WindowsPort.md as per #129 and other advisories Aug 12, 2025

citkane added 2 commits August 13, 2025 15:32

Update WindowsPort.md

23de9e0

Update WindowsPort.md

6beb1ae

donny-dont reviewed Aug 13, 2025

View reviewed changes

citkane added 3 commits August 13, 2025 18:36

Update WindowsPort.md

617bab2

Update WindowsPort.md

17f7833

Update WindowsPort.md

c413ea1

donny-dont reviewed Aug 13, 2025

View reviewed changes

Update WindowsPort.md

f17aab2

donny-dont reviewed Aug 13, 2025

View reviewed changes

citkane added 2 commits August 13, 2025 23:39

Update WindowsPort.md

8a3f853

Update WindowsPort.md

4e61b14

Update WindowsPort.md as per #129 and other advisories #130

Are you sure you want to change the base?

Update WindowsPort.md as per #129 and other advisories #130

Uh oh!

Conversation

citkane commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

donny-dont left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

citkane Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

donny-dont left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

citkane commented Aug 5, 2025 •

edited

Loading

citkane Aug 13, 2025 •

edited

Loading